Oscar Had A Heap Of Apples - Sine= Opposite over Hypotenuse, Cosine = Adjacent over Hypotenuse, Tangent = Opposite over Adjacent.
I've never seen a particularly
good mnemonic for this...and yours hasn't changed that!
That said, I reckon it's better than the ones my maths teachers at school tried to teach us and the fact that I can't remember any of those mnemonics is an indication of their quality.
To be fair, maths teaching in state schools in England in the 70s and 80s was in a pretty parlous state and the
one maths teacher who's name I
can recall, I only remember because he was a raging alcoholic who crashed his car into the deputy headmaster's car in the school car park at lunchtime after a visit to the local pub.
He was sacked but
only because during the 'frank exchange of views' between him and the deputy head in the car park, he called the deputy head's wife "a fat whore" (said wife, who was the school nurse, had seen the crash happen and alerted the deputy head; and yes, she was a fine figure of a woman...I may have had a bit of a schoolboy crush on her).
Schools were so short of maths teachers back then, a man who would drive drunk and slur his way through a maths lesson was considered perfectly employable.