For the most part, pump oilers are getting to be rather scarce. You probably won't find them in a hardware store anymore due to the advent of spray oil cans. The ones mentioned above are fine.
I go to swap meets and will buy every one of those that I find. I've probably got six or seven of them, I got three of them recently. I have them all over the place. I keep two at the lathe. One has cutting oil and the other has way oil. Some of them have regular motor oil in them. I mark them with black markers and renew the markings when they wear off.
No shop is complete without some pump oilers.